[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] xen: fix quad word bufioreq handling
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] xen: fix quad word bufioreq handling |
Date: |
Wed, 23 Nov 2016 10:01:10 -0800 (PST) |
User-agent: |
Alpine 2.10 (DEB 1266 2009-07-14) |
On Wed, 23 Nov 2016, Jan Beulich wrote:
> >>> On 23.11.16 at 11:45, <address@hidden> wrote:
> > No, if QEMU is using a default ioreq server (i.e. the legacy way of doing
> > things) then it's vulnerable to the guest messing with the rings and I'd
> > forgotten that migrated-in guests from old QEMUs also end up using the
> > default
> > server, so I guess this is a worthy checkt to make... although maybe it's
> > best to just bail if the check fails, since it would indicate a malicious
> > guest.
>
> Okay, that's basically the TBD note I have in the patch; I'll wait for
> at least one of the qemu maintainers to voice their preference.
I think we should just print an error and destroy_hvm_domain(false) or
hw_error if the check fails.
[Qemu-devel] [PATCH 2/3] xen: slightly simplify bufioreq handling, Jan Beulich, 2016/11/23
[Qemu-devel] [PATCH 3/3] xen: ignore direction in bufioreq handling, Jan Beulich, 2016/11/23