[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 05/18] tests/test-rbcache: add test cases
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v1 05/18] tests/test-rbcache: add test cases |
Date: |
Fri, 25 Nov 2016 11:11:04 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 25.11.2016 um 10:58 hat Pavel Butsykin geschrieben:
> On 24.11.2016 15:20, Kevin Wolf wrote:
> >Visualised, we test these requests:
> >
> >1: *
> >2: **
> >3: *
> >4: *******
> >5: ********
> >
> >You test inserting the only element, inserting after the last element,
> >inserting in the middle and inserting something that overlaps two other
> >requests at its start and end.
> >
> >That's a good start, but it might be worth testing more scenarios:
> >
> >- Inserting a new first element to a non-empty cache
>
> What do you mean? To insert an element with zero offset when the cache
> already contains other nodes.?
Yes, that would be one way to do it. Maybe just swap requests 1 and 2.
> >- Overlapping only at the start
> >- Overlapping only at the end
> >- Overlapping in the middle (i.e. including existing ranges as a
> > subset)
> > * With only one node
> > * With multiple nodes (like adding offset=2, size=16kb here)
> >
>
> Ok.
Kevin
- [Qemu-devel] [PATCH v1 00/18] I/O prefetch cache, Pavel Butsykin, 2016/11/15
- [Qemu-devel] [PATCH v1 07/18] block/pcache: skip large aio read, Pavel Butsykin, 2016/11/15
- [Qemu-devel] [PATCH v1 04/18] util/rbcache: range-based cache core, Pavel Butsykin, 2016/11/15
- [Qemu-devel] [PATCH v1 13/18] block/pcache: inflight readahead request waiting for aio read, Pavel Butsykin, 2016/11/15
- [Qemu-devel] [PATCH v1 10/18] block/pcache: skip readahead for unallocated clusters, Pavel Butsykin, 2016/11/15
- [Qemu-devel] [PATCH v1 05/18] tests/test-rbcache: add test cases, Pavel Butsykin, 2016/11/15
- [Qemu-devel] [PATCH v1 14/18] backup/pcache: pick up parts of the cache, Pavel Butsykin, 2016/11/15
- [Qemu-devel] [PATCH v1 08/18] block/pcache: updating statistics for overlapping requests, Pavel Butsykin, 2016/11/15
- [Qemu-devel] [PATCH v1 12/18] block/pcache: add reading data from the cache, Pavel Butsykin, 2016/11/15
- [Qemu-devel] [PATCH v1 03/18] util/rbtree: add rbtree from linux kernel, Pavel Butsykin, 2016/11/15
- [Qemu-devel] [PATCH v1 02/18] block/pcache: empty pcache driver filter, Pavel Butsykin, 2016/11/15
[Qemu-devel] [PATCH v1 06/18] block/pcache: statistics collection read requests, Pavel Butsykin, 2016/11/15
[Qemu-devel] [PATCH v1 11/18] block/pcache: cache invalidation on AIO write requests, Pavel Butsykin, 2016/11/15