Re: [Qemu-devel] [PATCH v2 40/47] trace: switch target/s390x/ directory to modular trace.h file

[Lluís Vilanova]

Daniel P Berrange writes:

> Switch files in the target/s390x/ directory to include the
> target/s390x/trace.h file instead of the global trace.h
> file.

> The make rules for gen-features.{h,c} need to be moved
> out into the top level Makefile.objs, otherwise make
> complains about the rules being defined multiple times
> due to target/s390x/Makefile.objs being included
> multiple times when expanding different subdir object
> lists.

If the problem is re-definition, you can instead add a guard around the rules in
target/s390x/Makefile.objs. This avoids defining the rules multiple times but
still keeps the target-specific rules in the target-specific makefile.


Cheers,
  Lluis