Re: [Qemu-devel] [PATCH v8 25/25] tcg: enable MTTCG by default for ARM on x86 hosts

[Richard Henderson]

On 01/27/2017 02:39 AM, Alex Bennée wrote:
> +/* This defines the natural memory order supported by this
> + * architecture before guarantees made by various barrier
> + * instructions.
> + *
> + * The x86 has a pretty strong memory ordering which only really
> + * allows for some stores to be re-ordered after loads.
> + */
> +#include "tcg-mo.h"
> +
> +static inline int get_tcg_target_mo(void)
> +{
> +    return TCG_MO_ALL & ~TCG_MO_LD_ST;
> +}
> +
> +#define TCG_TARGET_DEFAULT_MO get_tcg_target_mo()
> +

Why the inline function?  The expression in the define would seem sufficient. 
Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~