Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

[Andrew Jones]

On Thu, Feb 09, 2017 at 05:11:38PM +0100, Andrea Bolognani wrote:
> On Thu, 2017-02-09 at 16:35 +0100, Andrew Jones wrote:
> > > Please propose the alternative wording you'd like to see
> > > so we can discuss it :)
> > 
> > I guess I did above with "... -nodefaults ensures no non-builtin
> > peripherals are automatically added, but builtin peripherals,
> > such as the PL011, will remain..."
> 
> Trying to work your proposal into my most recent stab at
> this, I ended up with:
> 
>   Using -nodefaults is required to have full control over
>   the virtual hardware: when it's specified, QEMU will
>   populate the board with only the builtin peripherals,
>   such as the PL011 UART, plus a small selection of core
>   PCI devices and controllers; the user will then have to

Well, mach-virt doesn't currently add any pci devices with
-nodefault; just the host bridge. Personally, I'd state it that
way to avoid confusion, but I know you're trying to keep the
paragraph similar to the q35 one, and you're not technically
wrong...

>   esplicitly add further devices.

explicitly

> 
>   More specifically, the PCI devices that will always be
>   present in the guest are:
> 
>     00:00.0 Host bridge
> 
>   This configuration file adds a number of other...
> 
> Does it look acceptable?

I'm good with it.

Thanks,
drew