Re: [Qemu-devel] [PATCH] osdep.h: pull in sys/sysmacros.h for major/minor/makedev

[Peter Maydell]

On 10 February 2017 at 06:12, Mike Frysinger <address@hidden> wrote:
> Linux C libs are moving away from implicit header pollution with
> sys/types.h
>
> Signed-off-by: Mike Frysinger <address@hidden>
> ---
>  include/qemu/osdep.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 56c9e22405ec..6aaace6cf37f 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -85,6 +85,10 @@ extern int daemon(int, int);
>  #include <setjmp.h>
>  #include <signal.h>
>
> +#ifdef __linux__
> +#include <sys/sysmacros.h>
> +#endif
> +
>  #ifdef __OpenBSD__
>  #include <sys/signal.h>
>  #endif

I think there's already a patch on list for this that
does this (with a proper configure test).

I still think that it's a shame that glibc is breaking
compatibility with where these macros have always been
kept on every OS that's implemented them back to 2BSD...

thanks
-- PMM