Re: [Qemu-devel] [PULL 00/23] Misc patches for 2017-02-16

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL 00/23] Misc patches for 2017-02-16
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
a842dba target-i386: correctly propagate retaddr into SVM helpers
36f0d76 vl: log available guest crash information
5951e60 report guest crash information in GUEST_PANICKED event
e3d0196 i386/cpu: add crash-information QOM property
b22a547 Makefile: avoid leaving the temporary QEMU_PKGVERSION header file
1ac46cf vl: Move the cpu_synchronize_all_post_init() after generic devices 
initialization
ad5c282 qemu-nbd: Implement socket activation.
511652d qemu-doc: Clarify that -vga std is now the default
7ab8e56 cpu-exec: remove outermost infinite loop
8a13214 cpu-exec: avoid repeated sigsetjmp on interrupts
03e16ce cpu-exec: avoid cpu_loop_exit in cpu_handle_interrupt
4ff5c14 cpu-exec: tighten barrier on TCG_EXIT_REQUESTED
942cdfa cpu-exec: fix icount out-of-bounds access
91aa9ee hw/char/mcf_uart: QOMify the ColdFire UART
f437c15 gdbstub: Fix vCont behaviour
239bca2 move vm_start to cpus.c
5aab44b char: drop data written to a disconnected pty
f50cc4e apic: reset apic_delivered global variable on machine reset
d4b7bdc qemu-char: socket backend: disconnect on write error
26e8792 test-vmstate: remove yield_until_fd_readable
8394c0b kvm/ioapic: correct kvm ioapic version
30cb597 ioapic: fix error report value of def version
342745d kvm/ioapic: dump real object instead of a fake one

=== OUTPUT BEGIN ===
Checking PATCH 1/23: kvm/ioapic: dump real object instead of a fake one...
Checking PATCH 2/23: ioapic: fix error report value of def version...
Checking PATCH 3/23: kvm/ioapic: correct kvm ioapic version...
Checking PATCH 4/23: test-vmstate: remove yield_until_fd_readable...
Checking PATCH 5/23: qemu-char: socket backend: disconnect on write error...
Checking PATCH 6/23: apic: reset apic_delivered global variable on machine 
reset...
Checking PATCH 7/23: char: drop data written to a disconnected pty...
Checking PATCH 8/23: move vm_start to cpus.c...
Checking PATCH 9/23: gdbstub: Fix vCont behaviour...
Checking PATCH 10/23: hw/char/mcf_uart: QOMify the ColdFire UART...
Checking PATCH 11/23: cpu-exec: fix icount out-of-bounds access...
Checking PATCH 12/23: cpu-exec: tighten barrier on TCG_EXIT_REQUESTED...
ERROR: memory barrier without comment
#51: FILE: cpu-exec.c:559:
+        smp_mb();

total: 1 errors, 0 warnings, 13 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 13/23: cpu-exec: avoid cpu_loop_exit in cpu_handle_interrupt...
Checking PATCH 14/23: cpu-exec: avoid repeated sigsetjmp on interrupts...
Checking PATCH 15/23: cpu-exec: remove outermost infinite loop...
WARNING: line over 80 characters
#51: FILE: cpu-exec.c:633:
+         * Newer versions of gcc would complain about this code (-Wclobbered). 
*/

total: 0 errors, 1 warnings, 68 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 16/23: qemu-doc: Clarify that -vga std is now the default...
Checking PATCH 17/23: qemu-nbd: Implement socket activation....
Checking PATCH 18/23: vl: Move the cpu_synchronize_all_post_init() after 
generic devices initialization...
Checking PATCH 19/23: Makefile: avoid leaving the temporary QEMU_PKGVERSION 
header file...
Checking PATCH 20/23: i386/cpu: add crash-information QOM property...
Checking PATCH 21/23: report guest crash information in GUEST_PANICKED event...
Checking PATCH 22/23: vl: log available guest crash information...
Checking PATCH 23/23: target-i386: correctly propagate retaddr into SVM 
helpers...
WARNING: line over 80 characters
#76: FILE: target/i386/excp_helper.c:57:
+            cpu_vmexit(env, SVM_EXIT_SHUTDOWN, 0, retaddr); /* does not return 
*/

total: 0 errors, 1 warnings, 368 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden