Re: [Qemu-devel] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report()

[Krzysztof Kozlowski]

On Mon, Mar 06, 2017 at 10:55:12AM -0600, Eric Blake wrote:
> On 03/05/2017 03:48 PM, Krzysztof Kozlowski wrote:
> > error_report() is preferred over fprintf() for logging errors.  Also
> > remove square brackets [] and additional new line characters in printed
> > messages.
> > 
> > Signed-off-by: Krzysztof Kozlowski <address@hidden>
> > ---
> 
> I don't see a 0/3 cover letter. When sending multiple patches, it's
> always best to package them in-reply-to the cover letter ('git config
> format.coverLetter auto' makes it easy to remember).

The patches are trivial cleanups without any dependencies so the cover
letter would be one sentence of "trivial cleanup". :)

If that's the practice in qemu, I can send them, no problem.

> 
> 
> > @@ -101,9 +102,8 @@ static Exynos4210State 
> > *exynos4_boards_init_common(MachineState *machine,
> >      MachineClass *mc = MACHINE_GET_CLASS(machine);
> >  
> >      if (smp_cpus != EXYNOS4210_NCPUS && !qtest_enabled()) {
> > -        fprintf(stderr, "%s board supports only %d CPU cores. Ignoring 
> > smp_cpus"
> > -                " value.\n",
> > -                mc->name, EXYNOS4210_NCPUS);
> > +        error_report("%s board supports only %d CPU cores. Ignoring 
> > smp_cpus value.",
> 
> Most uses of error_report() avoid trailing dot.

Sure, I can rephrase it to one sentence without dot.

Best regards,
Krzysztof