Re: [Qemu-devel] [PATCH for-2.10 1/8] ppc/xics: add a xics_get_cpu_index_by_pir() helper

[Cédric Le Goater]

On 03/14/2017 06:38 AM, David Gibson wrote:
> On Wed, Mar 08, 2017 at 11:52:44AM +0100, Cédric Le Goater wrote:
>> This helper will be used to translate the server number of the XIVE
>> (which is a PIR) into an ICPState index number (which is a cpu index).
>>
>> Signed-off-by: Cédric Le Goater <address@hidden>
> 
> This seems a slightly roundabout way of doing things.  Why not just
> have the vcpu_by_pir() interface, then have the XICSFabric implementor
> go directly from PIR to xics server state.

So what you are saying is that we should try to move the "nature"
of the 'server' parameter of the xics framework in the icp_get() 
handler of the XICSFabric. Correct ? Because at the end, it all 
boils down to use a 'server' to look for an ICPState.

Each machine would do its conversion : 

        xics_get_cpu_index_by_dt_id() for spapr
        xics_get_cpu_index_by_pir() for powernv

C.