[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] trace: ensure $(tracetool-y) is defined in t
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] trace: ensure $(tracetool-y) is defined in top level makefile |
|
Date: |
Wed, 15 Mar 2017 07:59:11 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/15/2017 07:34 AM, Daniel P. Berrange wrote:
> The build rules for trace files have a dependancy on $(tracetool-y).
> This variable populated in the trace/Makefile.objs file and thus its
> definition gets pulled into the top level makefile. This happens too
> late in the process though, so by the time $(tracetool-y) is defined,
> make has already evaluated $(tracetool-y) in the dependancies and
> found it to be empty. The result is that when the tracetool source
> is changed, the generated files are not rebuilt. The solution is to
> define the variable in the top level makefile too
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> Makefile | 3 +++
> trace/Makefile.objs | 8 --------
> 2 files changed, 3 insertions(+), 8 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
Tested-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature