Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

[Paolo Bonzini]

On 16/03/2017 15:12, Gerd Hoffmann wrote:
>   Hi,
> 
>>> -#define DEPTH 8
>>> -#include "cirrus_vga_rop2.h"
>>> -
>>> -#define DEPTH 16
>>> -#include "cirrus_vga_rop2.h"
>>> -
>>> -#define DEPTH 24
>>> -#include "cirrus_vga_rop2.h"
>>> -
>>>  #define DEPTH 32
>>>  #include "cirrus_vga_rop2.h"
> 
> No.  It isn't *that* simple.  The cirrus blitter operates on the guest
> framebuffer, which can have any format the guest wishes it to have.
> This is *not* about rendering into a 32bpp DisplaySurface.

Besides that the patch is incomplete, since it doesn't adjust the users
of the ROP2 macro---this will probably apply to other display adapters
where you can do this kind of dead code removal.

Paolo