Re: [Qemu-devel] [PATCH 1/2] hw/acpi/vmgenid: prevent device realization on pre-2.9 machine types

[Paolo Bonzini]

On 20/03/2017 16:08, Laszlo Ersek wrote:
> (1) machine types up to and including 2.4 do not enable DMA for fw_cfg.
> Without DMA, the WRITE_POINTER linker/loader commands have no chance of
> working in the firmware.
> 
> (2) ... the other part of the problem was actually in my thinking, sorry
> about that. I forgot that that "-device vmgenid" itself is not available
> in QEMU releases prior to 2.9. So we shouldn't worry about the case
> where write support is missing from fw_cfg, although DMA is available.
> 
> In this patch I tried to address (non-)problem (2), thereby covering
> (real) problem (1). I now see that (2) doesn't actually exist. (1) does
> have to be addressed however.
> 
> If you agree, I'll respin this patch.

Yes, please do respin it with pre-2.4 machine types limited only.

Paolo