[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [for-2.9 2/8] char: Fix socket with "type": "vsock" add
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [for-2.9 2/8] char: Fix socket with "type": "vsock" address |
Date: |
Wed, 29 Mar 2017 20:59:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 29.03.2017 18:45, Markus Armbruster wrote:
> Watch this:
>
> $ qemu-system-x86_64 -nodefaults -S -display none -qmp stdio
> {"QMP": {"version": {"qemu": {"micro": 91, "minor": 8, "major": 2},
> "package": " (v2.8.0-1195-gf84141e-dirty)"}, "capabilities": []}}
> { "execute": "qmp_capabilities" }
> {"return": {}}
> { "execute": "chardev-add", "arguments": { "id": "chr0", "backend": {
> "type": "socket", "data": { "addr": { "type": "vsock", "data": { "cid":
> "CID", "port": "P" }}}}}}
> Aborted (core dumped)
>
> Crashes because SocketAddress_to_str() is blissfully unaware of
> SOCKET_ADDRESS_KIND_VSOCK. Fix that. Pick the output format to match
> socket_parse(), just like the existing formats.
>
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Marc-André Lureau <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> chardev/char-socket.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [for-2.9 7/8] nbd: Tidy up blockdev-add interface, (continued)