[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 for-2.9 07/10] sockets: New helper socket_addre
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC v2 for-2.9 07/10] sockets: New helper socket_address_crumple() |
Date: |
Thu, 30 Mar 2017 10:13:11 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/30/2017 10:03 AM, Markus Armbruster wrote:
>>> +SocketAddress *socket_address_crumple(SocketAddressFlat *addr_flat)
>>> +{
>>> + SocketAddress *addr = g_new(SocketAddress, 1);
>>> +
>>> + addr->type = addr_flat->type;
>>
>> Works only because our enum is defined in the same order as the simple
>> union's members. A bit fragile, so maybe we want to comment in the
>> .json file that we can't reorder members of either the enum or the
>> simple union's 'data'? Or it might even tickle a picky compiler to warn
>> about assignment between incompatible enum types. Another option would
>> be making it robust by instead doing switch(addr_flat->type) and
>> assigning to addr->type in each branch of the switch.
>
> Sold.
>
> Now looks like this:
>
> SocketAddress *socket_address_crumple(SocketAddressFlat *addr_flat)
> {
> SocketAddress *addr = g_new(SocketAddress, 1);
>
> switch (addr_flat->type) {
> case SOCKET_ADDRESS_FLAT_TYPE_INET:
> addr->type = SOCKET_ADDRESS_KIND_INET;
> addr->u.inet.data = QAPI_CLONE(InetSocketAddress,
> &addr_flat->u.inet);
> break;
Yes, that's better, and no tweaks to the .json file needed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [RFC v2 for-2.9 08/10] nbd: Tidy up blockdev-add interface, (continued)
- [Qemu-devel] [RFC v2 for-2.9 04/10] block: Document -drive problematic code and bugs, Markus Armbruster, 2017/03/30
- [Qemu-devel] [RFC v2 for-2.9 06/10] qapi-schema: SocketAddressFlat variants 'vsock' and 'fd', Markus Armbruster, 2017/03/30
- [Qemu-devel] [RFC v2 for-2.9 07/10] sockets: New helper socket_address_crumple(), Markus Armbruster, 2017/03/30
- [Qemu-devel] [RFC v2 for-2.9 01/10] nbd sockets vnc: Mark problematic address family tests TODO, Markus Armbruster, 2017/03/30
- [Qemu-devel] [RFC v2 for-2.9 02/10] char: Fix socket with "type": "vsock" address, Markus Armbruster, 2017/03/30
- Re: [Qemu-devel] [Qemu-block] [RFC v2 for-2.9 00/10] Fixes and cleanups around SocketAddress, Kashyap Chamarthy, 2017/03/30