[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 04/19] fdc: Remove user_creatable flag from sysbus-fdc
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC 04/19] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo |
Date: |
Fri, 31 Mar 2017 21:46:09 -0300 |
sysbus-fdc and SUNW,fdtwo devices need to be wired by the fdc
initialization code, and can't be used with -device. Unset
user_creatable on their device classes.
Cc: John Snow <address@hidden>
Cc: Kevin Wolf <address@hidden>
Cc: Max Reitz <address@hidden>
Cc: address@hidden
Cc: Thomas Huth <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/block/fdc.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index a06c8e358c..a328693d15 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -2880,11 +2880,6 @@ static void sysbus_fdc_class_init(ObjectClass *klass,
void *data)
dc->props = sysbus_fdc_properties;
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
- /*
- * FIXME: Set only for compatibility on q35 machine-type.
- * Probably never meant to be user-creatable
- */
- dc->user_creatable = true;
}
static const TypeInfo sysbus_fdc_info = {
@@ -2911,11 +2906,6 @@ static void sun4m_fdc_class_init(ObjectClass *klass,
void *data)
dc->props = sun4m_fdc_properties;
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
- /*
- * FIXME: Set only for compatibility on q35 machine-type.
- * Probably never meant to be user-creatable
- */
- dc->user_creatable = true;
}
static const TypeInfo sun4m_fdc_info = {
--
2.11.0.259.g40922b1
- [Qemu-devel] [RFC 00/19] sysbus: Don't allow -device/device_add by default, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 02/19] s390: Add FIXME for unexplained user_creatable=false line, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 01/19] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 04/19] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo,
Eduardo Habkost <=
- [Qemu-devel] [RFC 05/19] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 06/19] iommu: Remove FIXME comment about user_creatable=true, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 07/19] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 08/19] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 09/19] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 10/19] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 12/19] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 11/19] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31