Re: [Qemu-devel] [PATCH 10/43] s390x: made printf always compile in debug output

[Cornelia Huck]

On Sat, 1 Apr 2017 16:45:53 +0300
Danil Antonov <address@hidden> wrote:

> From ea9cd8f02bd98548435f561e62f4f9b672318bcb Mon Sep 17 00:00:00 2001
> From: Danil Antonov <address@hidden>
> Date: Wed, 29 Mar 2017 12:26:05 +0300
> Subject: [PATCH 10/43] s390x: made printf always compile in debug output

s/made/make/

(Not sure where the headers above came from; might be gmail.)

> 
> Wrapped printf calls inside debug macros (DPRINTF) in `if` statement.
> This will ensure that printf function will always compile even if debug
> output is turned off and, in turn, will prevent bitrot of the format
> strings.
> 
> Signed-off-by: Danil Antonov <address@hidden>
> ---
>  target/s390x/kvm.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

Seems reasonable; although we should convert to tracepoints later.

Queued for 2.10 (with the commit message slightly tweaked).