[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] migration/i386: Remove old non-softfloat 64
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] migration/i386: Remove old non-softfloat 64bit FP support |
Date: |
Wed, 05 Apr 2017 21:13:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Long long ago, we used to support storing the x86 FP registers in
> a 64bit format.
>
> Then c31da136a0bf8caad70c348f5ffc283206e9c7fc in v0.14-rc0 removed
> the last support for writing that in the migration format.
> Even before that, it was only used if you had softfloat disabled
> (i.e. !USE_X86LDOUBLE) so in practice use of it in even earlier
> qemu is unlikely for most users.
>
> Kill it off, it's complicated, and possibly broken.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Nice work.
It was a hack when I did it. I *think* that I was byte-by-byte
compatible with the C functions, but I was pretty sure that they didn't
worked even then.
Reviewed-by: Juan Quintela <address@hidden>
- [Qemu-devel] [PATCH 0/3 for 2.10] migration/i386 cleanup, Dr. David Alan Gilbert (git), 2017/04/05
- [Qemu-devel] [PATCH 1/3] migration/i386: Remove old non-softfloat 64bit FP support, Dr. David Alan Gilbert (git), 2017/04/05
- [Qemu-devel] [PATCH 2/3] vmstatification: i386 FPReg, Dr. David Alan Gilbert (git), 2017/04/05
- [Qemu-devel] [PATCH 3/3] migration/i386: Remove support for pre-0.12 formats, Dr. David Alan Gilbert (git), 2017/04/05
- Re: [Qemu-devel] [PATCH 0/3 for 2.10] migration/i386 cleanup, Juan Quintela, 2017/04/05
- Re: [Qemu-devel] [PATCH 0/3 for 2.10] migration/i386 cleanup, Eduardo Habkost, 2017/04/13