[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 19/54] ram: Move iterations into RAMState
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 19/54] ram: Move iterations into RAMState |
Date: |
Thu, 6 Apr 2017 15:08:38 +0200 |
Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
---
migration/ram.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 85d66ea..3e500ae 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -170,6 +170,8 @@ struct RAMState {
uint64_t zero_pages;
/* number of normal transferred pages */
uint64_t norm_pages;
+ /* Iterations since start */
+ uint64_t iterations;
};
typedef struct RAMState RAMState;
@@ -177,7 +179,6 @@ static RAMState ram_state;
/* accounting for migration statistics */
typedef struct AccountingInfo {
- uint64_t iterations;
uint64_t xbzrle_bytes;
uint64_t xbzrle_pages;
uint64_t xbzrle_cache_miss;
@@ -693,13 +694,13 @@ static void migration_bitmap_sync(RAMState *rs)
}
if (migrate_use_xbzrle()) {
- if (rs->iterations_prev != acct_info.iterations) {
+ if (rs->iterations_prev != rs->iterations) {
acct_info.xbzrle_cache_miss_rate =
(double)(acct_info.xbzrle_cache_miss -
rs->xbzrle_cache_miss_prev) /
- (acct_info.iterations - rs->iterations_prev);
+ (rs->iterations - rs->iterations_prev);
}
- rs->iterations_prev = acct_info.iterations;
+ rs->iterations_prev = rs->iterations;
rs->xbzrle_cache_miss_prev = acct_info.xbzrle_cache_miss;
}
s->dirty_pages_rate = rs->num_dirty_pages_period * 1000
@@ -1994,6 +1995,7 @@ static int ram_save_init_globals(RAMState *rs)
rs->bitmap_sync_count = 0;
rs->zero_pages = 0;
rs->norm_pages = 0;
+ rs->iterations = 0;
migration_bitmap_sync_init(rs);
qemu_mutex_init(&migration_bitmap_mutex);
@@ -2151,7 +2153,7 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
done = 1;
break;
}
- acct_info.iterations++;
+ rs->iterations++;
/* we want to check in the 1st loop, just in case it was the 1st time
and we had to sync the dirty bitmap.
--
2.9.3
- Re: [Qemu-devel] [PATCH 09/54] ram: Change byte_xfer_now type to uint64_t, (continued)
- [Qemu-devel] [PATCH 11/54] ram: Change num_dirty_pages_period type to uint64_t, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 10/54] ram: Move num_dirty_pages_period into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 13/54] ram: Move iterations_prev into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 12/54] ram: Move xbzrle_cache_miss_prev into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 14/54] ram: Move dup_pages into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 15/54] ram: Remove unused dup_mig_bytes_transferred(), Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 16/54] ram: Remove unused pages_skipped variable, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 19/54] ram: Move iterations into RAMState,
Juan Quintela <=
- [Qemu-devel] [PATCH 20/54] ram: Move xbzrle_bytes into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 18/54] ram: Remove norm_mig_bytes_transferred, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 21/54] ram: Move xbzrle_pages into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 22/54] ram: Move xbzrle_cache_miss into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 17/54] ram: Move norm_pages to RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 23/54] ram: Move xbzrle_cache_miss_rate into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 24/54] ram: Move xbzrle_overflows into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 25/54] ram: Move migration_dirty_pages to RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 26/54] ram: Everything was init to zero, so use memset, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 27/54] ram: Move migration_bitmap_mutex into RAMState, Juan Quintela, 2017/04/06