[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/13] qobject: Drop useless QObject casts
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/13] qobject: Drop useless QObject casts |
Date: |
Fri, 7 Apr 2017 10:04:47 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, Apr 05, 2017 at 02:47:33PM -0500, Eric Blake wrote:
> We have macros in place to make it less verbose to add a subtype
> of QObject to both QDict and QList. While we have made cleanups
> like this in the past (see commit fcfcd8ffc, for example), having
> it be automated by Coccinelle makes it easier to maintain.
>
> Patch created mechanically via:
> spatch --sp-file scripts/coccinelle/qobject.cocci \
> --macro-file scripts/cocci-macro-file.h --dir . --in-place
> then I verified that no manual touchups were required.
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
> block.c | 12 ++++--------
> block/blkdebug.c | 4 ++--
> block/blkverify.c | 7 +++----
> block/file-posix.c | 6 +++---
> block/file-win32.c | 4 ++--
> block/quorum.c | 16 ++++++----------
> tests/check-qdict.c | 20 ++++++++++----------
> tests/test-qmp-commands.c | 24 ++++++++++++------------
> 8 files changed, 42 insertions(+), 51 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v3 04/13] coccinelle: Add script to remove useless QObject casts, (continued)
- [Qemu-devel] [PATCH v3 04/13] coccinelle: Add script to remove useless QObject casts, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 03/13] s390x: Drop useless casts, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 06/13] qobject: Add helper macros for common scalar insertions, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 05/13] qobject: Drop useless QObject casts, Eric Blake, 2017/04/05
- Re: [Qemu-devel] [PATCH v3 05/13] qobject: Drop useless QObject casts,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v3 08/13] tests: Use simpler QDict/QList scalar insertion macros, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 11/13] QemuOpts: Simplify qemu_opts_to_qdict(), Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 10/13] block: Simplify bdrv_append_temp_snapshot() logic, Eric Blake, 2017/04/05
[Qemu-devel] [PATCH v3 07/13] block: Use simpler QDict/QList scalar insertion macros, Eric Blake, 2017/04/05