Re: [Qemu-devel] [PATCH v2] qxl: add migration blocker to avoid pre-save assert

[Marc-André Lureau]

Hi

On Mon, Apr 10, 2017 at 12:51 PM Gerd Hoffmann <address@hidden> wrote:

>   Hi,
>
> > > +                if (!qxl->migration_blocker) {
> > > +                    Error *local_err = NULL;
> > > +                    error_setg(&qxl->migration_blocker,
> > > +                               "qxl: guest bug: command not in ram
> bar");
> > > +                    migrate_add_blocker(qxl->migration_blocker,
> > > &local_err);
> > >
> >
> > What do you do with the local_err? error_report_err() perhaps ?
>
> We can't error out at that point, unlike most migration blockers this
> isn't added at device initialization time.
>
> So, yes, we could error_report it, but the message would end up in the
> logfile unnoticed, so I'm not sure how useful that is ...
>

Well, it may eventually be read if something breaks. Otherwise, you may
just pass a NULL pointer, no?

thanks
-- 
Marc-André Lureau