[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/19] migration: Export exec.c functions in its
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [PATCH 05/19] migration: Export exec.c functions in its own file |
|
Date: |
Tue, 18 Apr 2017 12:13:16 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote:
> On 17/04/2017 22:00, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> include/migration/exec.h | 20 ++++++++++++++++++++
>
> Good cleanup, but please move it to migration/exec.h and include it with
> "exec.h". This is the standard for files that are not needed outside
> that particular directory.
Aha, thanks. I was thinking about creating something "internal", but
that makes sense.
Later, Juan.
- [Qemu-devel] [PATCH 00/19] Migration cleanup, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 02/19] migration: They are called vmstate_foo, move them to vmstate.c, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 01/19] migration: to_dst_file at that point is NULL, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 03/19] migration: Split migration/channel.c for channel operations, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 04/19] migration: Remove MigrationState from migration_channel_incomming(), Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 05/19] migration: Export exec.c functions in its own file, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 06/19] migration: Export fd.c functions in its own file, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 07/19] migration: Export socket.c functions in its own file, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 08/19] migration: Export tls.c functions in its own file, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 09/19] migration: Create block capabilities for shared and enable, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 10/19] migration: Remove use of old MigrationParams, Juan Quintela, 2017/04/17