[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC for-3.0 4/4] block/qcow2-rust: Register block driv
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [RFC for-3.0 4/4] block/qcow2-rust: Register block driver |
Date: |
Wed, 19 Apr 2017 14:19:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 19.04.2017 13:28, Fam Zheng wrote:
> On Sat, 04/01 17:57, Max Reitz wrote:
>> +/* This is just for the module loading system to detect this driver */
>> +static BlockDriver _ __attribute__((used)) = {
>> + .format_name = "qcow2-rust",
>> +};
>
> You see why I didn't like that system in the first place.
Yes. We will have to adjust the module loading system before 3.0, but
I'm confident we can port all block drivers to Rust by then so this will
be a matter of course.
OTOH, why would you ever not load the rust block driver? In the final
version, we'd call it "qcow2", throw the legacy driver out and not even
care about whether the module system detects this one (because it'll be
statically linked anyway).
(Honestly, I think this is just an artifact from beginning of last week
where I wanted to make this driver a module... Beware, my April Fool's
patches may not be polished.)
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC for-3.0 0/4] block: Add qcow2-rust block driver, Max Reitz, 2017/04/18
- [Qemu-devel] [RFC for-3.0 2/4] block/qcow2-rust: Add qcow2-rust block driver, Max Reitz, 2017/04/18
- [Qemu-devel] [RFC for-3.0 1/4] block: Add Rust interface, Max Reitz, 2017/04/18
- [Qemu-devel] [RFC for-3.0 3/4] block/qcow2-rust: Add partial write support, Max Reitz, 2017/04/18
- [Qemu-devel] [RFC for-3.0 4/4] block/qcow2-rust: Register block driver, Max Reitz, 2017/04/18
- Re: [Qemu-devel] [RFC for-3.0 0/4] block: Add qcow2-rust block driver, no-reply, 2017/04/18
- Re: [Qemu-devel] [RFC for-3.0 0/4] block: Add qcow2-rust block driver, no-reply, 2017/04/18
- Re: [Qemu-devel] [RFC for-3.0 0/4] block: Add qcow2-rust block driver, Marc-André Lureau, 2017/04/18
- Re: [Qemu-devel] [RFC for-3.0 0/4] block: Add qcow2-rust block driver, no-reply, 2017/04/18
- Re: [Qemu-devel] [Qemu-block] [RFC for-3.0 0/4] block: Add qcow2-rust block driver, Stefan Hajnoczi, 2017/04/21