[Qemu-devel] 答复: Re: [PATCH] qemu-ga: addguest-network-get-interface-stat command

[lu.zhipeng]

ok,i agreed. i will do it
















为了让您的VPlat虚拟化故障得到高效的处理，请上报故障到: $VPlat技术支持。


芦志朋 luzhipeng






IT开发工程师 IT Development
Engineer
操作系统产品部/中心研究院/系统产品 OS Product Dept./Central R＆D Institute/System Product









深圳市南山区科技南路55号中兴通讯研发大楼33楼 
33/F, R&D Building, ZTE
Corporation Hi-tech Road South, 
Hi-tech
Industrial Park Nanshan District, Shenzhen, P.R.China, 518057 
T: +86 755 xxxxxxxx F:+86 755 xxxxxxxx 
M: +86 xxxxxxxxxxx 
E: address@hidden 
www.zte.com.cn








原始邮件



发件人： address@hidden
收件人： address@hidden
抄送人：芦志朋10108272 address@hidden address@hidden
日 期 ：2017年04月19日 19:58
主 题 ：Re: [Qemu-devel] [PATCH] qemu-ga: addguest-network-get-interface-stat 
command





On Wed, 19 Apr 2017 12:50:36 +0100
"Daniel P. Berrange" address@hidden wrote:

＞ On Wed, Apr 19, 2017 at 01:41:47PM +0200, Cornelia Huck wrote:
＞ ＞ On Thu, 20 Apr 2017 00:57:08 +0800
＞ ＞ ZhiPeng Lu address@hidden wrote:
＞ ＞ 
＞ ＞ ＞ diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
＞ ＞ ＞ index a02dbf2..60111dc 100644
＞ ＞ ＞ --- a/qga/qapi-schema.json
＞ ＞ ＞ +++ b/qga/qapi-schema.json
＞ ＞ ＞ @@ -1042,3 +1042,37 @@
＞ ＞ ＞    'data':    { 'path': 'str', '*arg': ['str'], '*env': ['str'],
＞ ＞ ＞                 '*input-data': 'str', '*capture-output': 'bool' },
＞ ＞ ＞    'returns': 'GuestExec' }
＞ ＞ ＞ +##
＞ ＞ ＞ +# @GuestNetworkInterfaceStat:
＞ ＞ ＞ +#
＞ ＞ ＞ +# @rx_bytes: received bytes of interface
＞ ＞ ＞ +#
＞ ＞ ＞ +# @rx_packets: received packets of interface
＞ ＞ ＞ +#
＞ ＞ ＞ +# @rx_errs: received error packets of interface
＞ ＞ ＞ +# @rx_drop: received drop packets of interface
＞ ＞ ＞ +#
＞ ＞ ＞ +# Since: 2.10
＞ ＞ ＞ +##
＞ ＞ ＞ +{ 'struct': 'GuestNetworkInterfaceStat',
＞ ＞ ＞ +  'data': {'rx_bytes': 'uint64',
＞ ＞ ＞ +            'rx_packets': 'uint64',
＞ ＞ ＞ +            'rx_errs': 'uint64',
＞ ＞ ＞ +            'rx_drop': 'uint64',
＞ ＞ ＞ +            'tx_bytes': 'uint64',
＞ ＞ ＞ +            'tx_packets': 'uint64',
＞ ＞ ＞ +            'tx_errs': 'uint64',
＞ ＞ ＞ +            'tx_drop': 'uint64'
＞ ＞ ＞ +           } }
＞ ＞ ＞ +##
＞ ＞ ＞ +# @guest-network-get-interface-stat:
＞ ＞ ＞ +#
＞ ＞ ＞ +# Get list of interface stat
＞ ＞ ＞ +#
＞ ＞ ＞ +# Returns: List of GuestNetworkInterfaceStat on success.
＞ ＞ ＞ +#
＞ ＞ ＞ +# Since: 2.10
＞ ＞ ＞ +##
＞ ＞ ＞ +{ 'command': 'guest-network-get-interface-stat',
＞ ＞ ＞ +  'data':    {'bus': 'int64', 'slot': 'int64', 'function': 
'int64','netname':'str'},
＞ ＞ ＞ +  'returns': ['GuestNetworkInterfaceStat'] }
＞ ＞ 
＞ ＞ Disregarding the question whether this command should be added to the
＞ ＞ guest agent (I'll leave that to others to discuss), I don't think it's
＞ ＞ a good idea to enshrine pci identifiers here, as it means that we would
＞ ＞ need to add a new interface for every non-pci network device.
＞ ＞ 
＞ ＞ Can you use a more general device identifier interface? It's fine to
＞ ＞ only support pci for now (as that is likely your use case anyway), but
＞ ＞ there should be a way to extend this in the future.
＞ 
＞ It would be better to match the identification approach uses for the
＞ existing guest-network-get-interfaces command, which is based on MAC
＞ address. Arguably the stats data could just be added to this existnig
＞ command instead of adding a new command.

Agreed, that sounds like a better choice.