[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Test postcopy migration
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Test postcopy migration |
|
Date: |
Thu, 20 Apr 2017 15:39:17 +0100 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Thu, Apr 20, 2017 at 10:18:27PM +0800, Fam Zheng wrote:
> On Wed, 04/19 17:16, Kevin Wolf wrote:
> > +_supported_fmt generic
>
> This doesn't work for formats that install migration blockers, so maybe
> s/generic/raw qcow2/ instead?
It would be nice to use a more feature driven check and centralize
knowledge of which formats are migratable. eg define a
"_migratable_fmt" function in common.rc that checks a MIGRATABLE_FMT
env variable, and in 'common' where we process the command line args,
set MIGRATABLE_FMT for each format or protocol as needed.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|