Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

[Juan Quintela]

Laurent Vivier <address@hidden> wrote:
> On 25/04/2017 12:24, Juan Quintela wrote:
>> This way we use the "normal" way of printing errors for hmp commands.
>> 
>> --
>> Paolo suggestion
>
> "Suggested-by" tag?

Thanks.
>>  {
>> +    Error *err = NULL;
>> +
>>      if (replay_snapshot) {
>>          if (replay_mode == REPLAY_MODE_RECORD) {
>> -            if (save_vmstate(replay_snapshot) != 0) {
>> +            if (save_vmstate(replay_snapshot, &err) != 0) {
>>                  error_report("Could not create snapshot for icount record");
>>                  exit(1);
>>              }
>>          } else if (replay_mode == REPLAY_MODE_PLAY) {
>> -            if (load_vmstate(replay_snapshot) != 0) {
>> +            if (load_vmstate(replay_snapshot, &err) != 0) {
>>                  error_report("Could not load snapshot for icount replay");
>>                  exit(1);
>>              }
>
> You can use "&error_fatal" in these cases.

I was very happy with your suggestion.  But then I realized that if I
use error_fatal, I would lost the error_report() messages, right?

Later, Juan.