[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 2/8] qga-win: Enable 'can-offline' field in 'guest
From: |
Michael Roth |
Subject: |
[Qemu-devel] [PULL v2 2/8] qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply |
Date: |
Thu, 27 Apr 2017 00:46:30 -0500 |
From: Sameeh Jubran <address@hidden>
The QGA schema states:
@can-offline: Whether offlining the VCPU is possible. This member
is always filled in by the guest agent when the structure
is returned, and always ignored on input (hence it can be
omitted then).
Currently 'can-offline' is missing entirely from the reply. This causes
errors in libvirt which is expecting the reply to be compliant with the
schema docs.
BZ#1438735: https://bugzilla.redhat.com/show_bug.cgi?id=1438735
Signed-off-by: Sameeh Jubran <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Cc: address@hidden
Signed-off-by: Michael Roth <address@hidden>
---
qga/commands-win32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 04026ee..9fec1fb 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -1344,7 +1344,7 @@ GuestLogicalProcessorList *qmp_guest_get_vcpus(Error
**errp)
vcpu = g_malloc0(sizeof *vcpu);
vcpu->logical_id = current++;
vcpu->online = true;
- vcpu->has_can_offline = false;
+ vcpu->has_can_offline = true;
entry = g_malloc0(sizeof *entry);
entry->value = vcpu;
--
2.7.4
- [Qemu-devel] [PULL v2 0/8] qemu-ga patch queue, Michael Roth, 2017/04/27
- [Qemu-devel] [PULL v2 2/8] qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply,
Michael Roth <=
- [Qemu-devel] [PULL v2 3/8] qga-win: Fix a bug where qemu-ga service is stuck during stop operation, Michael Roth, 2017/04/27
- [Qemu-devel] [PULL v2 7/8] qga: Add 'guest-get-users' command, Michael Roth, 2017/04/27
- [Qemu-devel] [PULL v2 6/8] qga: improve fsfreeze documentations, Michael Roth, 2017/04/27
- [Qemu-devel] [PULL v2 4/8] qga-win: Fix Event Viewer errors caused by qemu-ga, Michael Roth, 2017/04/27
- [Qemu-devel] [PULL v2 5/8] qga: Add 'guest-get-host-name' command, Michael Roth, 2017/04/27
- [Qemu-devel] [PULL v2 1/8] qemu-ga: Make QGA VSS provider service run only when needed, Michael Roth, 2017/04/27
- [Qemu-devel] [PULL v2 8/8] qga: Add `guest-get-timezone` command, Michael Roth, 2017/04/27
- Re: [Qemu-devel] [PULL v2 0/8] qemu-ga patch queue, Stefan Hajnoczi, 2017/04/28