[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scsi: avoid an off-by-one error in megasas_mmio
From: |
P J P |
Subject: |
Re: [Qemu-devel] [PATCH] scsi: avoid an off-by-one error in megasas_mmio_write |
Date: |
Fri, 28 Apr 2017 16:33:05 +0530 (IST) |
+-- On Fri, 28 Apr 2017, Paolo Bonzini wrote --+
| > | /* Magic sequence to start ADP reset */
| > | - if (adp_reset_seq[s->adp_reset] == val) {
| > | - s->adp_reset++;
| > | + if (adp_reset_seq[s->adp_reset++] == val) {
| > | + if (s->adp_reset == 6) {
| > | + s->adp_reset = 0;
| > | + s->diag = MFI_DIAG_WRITE_ENABLE;
| > | + }
| > | } else {
| > | s->adp_reset = 0;
| > | s->diag = 0;
| > | }
| > | - if (s->adp_reset == 6) {
| > | - s->diag = MFI_DIAG_WRITE_ENABLE;
| > | - }
| > | break;
|
| I've already queued this patch.
Oh, okay. Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F