Re: [Qemu-devel] [PATCH 2/2] cg3: add explicit ram_addr_t cast to scanline page variable

[Philippe Mathieu-Daudé]

On 05/01/2017 04:39 AM, Mark Cave-Ayland wrote:
> Coverity warns that multiplying two 32-bit values gives a 32-bit result which
> is assigned to a 64-bit variable. Add an explicit ram_addr_t cast to silence
> the warning.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  hw/display/cg3.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/cg3.c b/hw/display/cg3.c
> index 03d9197..7ef8a96 100644
> --- a/hw/display/cg3.c
> +++ b/hw/display/cg3.c
> @@ -113,7 +113,7 @@ static void cg3_update_display(void *opaque)
>      for (y = 0; y < height; y++) {
>          int update = s->full_update;
>
> -        page = y * width;
> +        page = (ram_addr_t)y * width;
>          update |= memory_region_get_dirty(&s->vram_mem, page, width,
>                                            DIRTY_MEMORY_VGA);
>          if (update) {