[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-l
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line |
Date: |
Tue, 2 May 2017 19:51:46 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, May 02, 2017 at 04:42:02PM -0500, Eric Blake wrote:
[...]
> > - if (value) {
> > - cpu->env.features[fp->w] |= fp->mask;
> > - } else {
> > - cpu->env.features[fp->w] &= ~fp->mask;
> > + switch (value->type) {
> > + case QTYPE_QBOOL:
> > + if (value->u.q_bool) {
> > + cpu->env.features[fp->w] |= fp->mask;
> > + } else {
> > + cpu->env.features[fp->w] &= ~fp->mask;
> > + }
> > + cpu->env.forced_features[fp->w] &= ~fp->mask;
> > + cpu->env.user_features[fp->w] |= fp->mask;
> > + break;
>
> Isn't the break supposed to be indented four more spaces?
>
[...]
I will fix it in v2. Thanks!
--
Eduardo
- Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types, (continued)
- Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types, Markus Armbruster, 2017/05/04
- Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types, Eduardo Habkost, 2017/05/04
- Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types, Eduardo Habkost, 2017/05/04
- Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types, Eric Blake, 2017/05/04
- Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types, Eduardo Habkost, 2017/05/04
- Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types, Markus Armbruster, 2017/05/05
- [Qemu-devel] [PATCH 3/4] tests: Add [+-]feature and feature=on|off test cases, Eduardo Habkost, 2017/05/02
- [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line, Eduardo Habkost, 2017/05/02
- Re: [Qemu-devel] [PATCH 0/4] x86: Support "-cpu feature=force", no-reply, 2017/05/02
- Re: [Qemu-devel] [PATCH 0/4] x86: Support "-cpu feature=force", no-reply, 2017/05/02