Re: [Qemu-devel] [Qemu-arm] [PATCH 2/3] hw/intc/exynos: Constify array of combiner interrupts

[Philippe Mathieu-Daudé]

On 05/07/2017 08:35 AM, Krzysztof Kozlowski wrote:
> The static array of interrupt combiner mappings is not modified so it
> can be made const for code safeness.
>
> Signed-off-by: Krzysztof Kozlowski <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  hw/intc/exynos4210_gic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/exynos4210_gic.c b/hw/intc/exynos4210_gic.c
> index 222cfd6c6387..636dc6dbc1f9 100644
> --- a/hw/intc/exynos4210_gic.c
> +++ b/hw/intc/exynos4210_gic.c
> @@ -116,7 +116,7 @@ enum ExtInt {
>   * which is INTG16 in Internal Interrupt Combiner.
>   */
>
> -static uint32_t
> +static const uint32_t
>  combiner_grp_to_gic_id[64-EXYNOS4210_MAX_EXT_COMBINER_OUT_IRQ][8] = {
>      /* int combiner groups 16-19 */
>      { }, { }, { }, { },