[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 4/4] utils: remove assert in size_to_str()
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v7 4/4] utils: remove assert in size_to_str() |
|
Date: |
Thu, 11 May 2017 20:22:03 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 05/11/2017 07:22 AM, Peter Xu wrote:
>> It's not very safe to assert in size_to_str(). Let's be inclusive.
>>
>> It naturally allows negative values. Now it won't even limit on the
>> size, as long as double would allow.
>>
>> Signed-off-by: Peter Xu <address@hidden>
>> ---
>> util/cutils.c | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> Since you just introduced this in 2/4, I'd rather see the two squashed
> together if we decide this is the interface we want to support.
PATCH 2 factors it out of print_type_size(). Doing just that and
improving only on top makes some sense.