[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/6] tcg: move the tcg files into tcg/ subdir
From: |
Zhong Yang |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/6] tcg: move the tcg files into tcg/ subdirectory. |
Date: |
Thu, 1 Jun 2017 20:04:54 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jun 01, 2017 at 10:14:34AM +0200, Paolo Bonzini wrote:
>
>
> On 01/06/2017 07:27, Zhong Yang wrote:
> > In the first phase, there are three patchsets to
> > deal with split code and separate the files.
> > 1) split the tcg exec code.
> > a)split the tcg accelerators from accel.c file and re-name
> > tcg accelerator to tcg-all.c, like kvm-all.c did.
> > b)create one accel directory, which will include kvm,
> > tcg and general exec files.
> > c)move tcg exec files into ./accel/tcg directory.
> > 2) move tcg related backend files into tcg/ directory
> > those files include translate-all.(ch), translate-common.c,
> > tci.c and tcg-runtime.c.
> > 3) move kvm exec and exec.c file.
> > a)move kvm related exec files into ./accel/kvm directory.
> > b)move exec.c in ./accel directory.
> >
> > after 1) and 3) done, the file tree like below:
> > accel/
> > ├── accel.c
> > ├── exec.c
> > ├── kvm
> > │ ├── kvm-all.c
> > │ ├── kvm-stub.c
> > │ ├── Makefile.objs
> > │ └── trace-events
> > ├── Makefile.objs
> > └── tcg
> > ├── cpu-exec.c
> > ├── cpu-exec-common.c
> > ├── cputlb.c
> > ├── Makefile.objs
> > ├── tcg-all.c
> > └── trace-events
> >
> > please help me check whether this kind of arrange is suitable?
>
> Oh, I see now. I think translate-all.[ch] and translate-common.c belong
> in accel/tcg more than tcg/.
okay, i will make those changes into one patchset and send v3 to all, thanks!
Yang.
>
> Thanks,
>
> Paolo