[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 23/33] exec: fix address_space_get_iotlb_entry pa
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PULL 23/33] exec: fix address_space_get_iotlb_entry page mask |
Date: |
Fri, 2 Jun 2017 17:59:23 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Jun 01, 2017 at 02:41:41PM +0200, Paolo Bonzini wrote:
> From: Peter Xu <address@hidden>
>
> The IOTLB that it returned didn't guarantee that page_mask is indeed a
> so-called page mask. That won't affect current usage since now only
> vhost is using it (vhost API allows arbitary IOTLB range). However we
> have IOTLB scemantic and we should best follow it. This patch fixes this
> issue to make sure the page_mask is always a valid page mask.
>
> Fixes: a764040 ("exec: abstract address_space_do_translate()")
> Signed-off-by: Peter Xu <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> exec.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 29633cd..22b8f0c 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -528,16 +528,14 @@ IOMMUTLBEntry
> address_space_get_iotlb_entry(AddressSpace *as, hwaddr addr,
> section.offset_within_region;
>
> if (plen == (hwaddr)-1) {
> - /*
> - * We use default page size here. Logically it only happens
> - * for identity mappings.
> - */
> - plen = TARGET_PAGE_SIZE;
> + /* If not specified during translation, use default mask */
> + plen = TARGET_PAGE_MASK;
> + } else {
> + /* Make it a valid page mask */
> + assert(plen);
> + plen = pow2floor(plen) - 1;
> }
>
> - /* Convert to address mask */
> - plen -= 1;
> -
> return (IOMMUTLBEntry) {
> .target_as = section.address_space,
> .iova = addr & ~plen,
> --
> 1.8.3.1
Paolo,
I got a better idea on refactoring address_space_get_iotlb_entry(). If
you haven't started preparing another pull request, please feel free
to drop this one (it fixed the problem but not that complete).
Otherwise I'll just work upon it, which is fine as well.
Sorry for the troublesome.
--
Peter Xu
- [Qemu-devel] [PULL 17/33] vhost-user-scsi: Introduce vhost-user-scsi host device, (continued)
[Qemu-devel] [PULL 19/33] target/i386: enable A20 automatically in system management mode, Paolo Bonzini, 2017/06/01
[Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce a vhost-user-scsi sample application, Paolo Bonzini, 2017/06/01
[Qemu-devel] [PULL 21/33] i386: fix read/write cr with icount option, Paolo Bonzini, 2017/06/01
[Qemu-devel] [PULL 20/33] target/i386: use multiple CPU AddressSpaces, Paolo Bonzini, 2017/06/01
[Qemu-devel] [PULL 23/33] exec: fix address_space_get_iotlb_entry page mask, Paolo Bonzini, 2017/06/01
- Re: [Qemu-devel] [PULL 23/33] exec: fix address_space_get_iotlb_entry page mask,
Peter Xu <=
[Qemu-devel] [PULL 24/33] nbd: Fully initialize client in case of failed negotiation, Paolo Bonzini, 2017/06/01
[Qemu-devel] [PULL 22/33] sockets: improve error reporting if UNIX socket path is too long, Paolo Bonzini, 2017/06/01
[Qemu-devel] [PULL 26/33] kvmclock: update system_time_msr address forcibly, Paolo Bonzini, 2017/06/01
[Qemu-devel] [PULL 25/33] qtest: add rtc periodic timer test, Paolo Bonzini, 2017/06/01
[Qemu-devel] [PULL 27/33] linuxboot_dma: compile for i486, Paolo Bonzini, 2017/06/01
[Qemu-devel] [PULL 28/33] edu: fix memory leak on msi_broken platforms, Paolo Bonzini, 2017/06/01
[Qemu-devel] [PULL 30/33] target/i386: Add GDB XML description for SSE registers, Paolo Bonzini, 2017/06/01