[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 17/22] qemu-ga: remove useless allocation
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 17/22] qemu-ga: remove useless allocation |
Date: |
Sun, 4 Jun 2017 18:45:21 +0300 |
From: Marc-André Lureau <address@hidden>
There is no need to duplicate a fixed string.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
qga/commands-posix.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 284ecc6d7e..d8e412275e 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -2197,12 +2197,10 @@ static void transfer_memory_block(GuestMemoryBlock
*mem_blk, bool sys2memblk,
}
} else {
if (mem_blk->online != (strncmp(status, "online", 6) == 0)) {
- char *new_state = mem_blk->online ? g_strdup("online") :
- g_strdup("offline");
+ const char *new_state = mem_blk->online ? "online" : "offline";
ga_write_sysfs_file(dirfd, "state", new_state, strlen(new_state),
&local_err);
- g_free(new_state);
if (local_err) {
error_free(local_err);
result->response =
--
2.11.0
- [Qemu-devel] [PULL 00/22] Trivial patches for 2017-06-04, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 02/22] qemu-doc: Add hyperlinks to further license information, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 08/22] trivial: Remove unneeded ifndef in memory.h, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 10/22] target/arm: add data cache invalidation cp15 instruction to cortex-r5, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 07/22] altera_timer: fix incorrect memset, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 05/22] tests/libqtest: Print error instead of aborting when env variable is missing, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 22/22] hw/core: nmi.c can be compiled as common-obj nowadays, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 11/22] hw/xtensa: sim: use g_string/g_new, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 14/22] hw/mips: add missing include, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 01/22] qemu-doc: Move the qemu-ga description into a separate chapter, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 17/22] qemu-ga: remove useless allocation,
Michael Tokarev <=
- [Qemu-devel] [PULL 19/22] ide-test: check return of fwrite, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 15/22] qapi: Fix some QMP documentation regressions, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 18/22] help: Add newline to end of thread option help text, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 04/22] docs/qdev-device-use.txt: update section Default Devices, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 13/22] register: display register prefix (name) since it is available, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 20/22] dump: fix memory_mapping_filter leak, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 03/22] docs qemu-doc: Avoid ide-drive, it's deprecated, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 16/22] scsi/lsi53c895a: Remove unused lsi_mem_*() return value, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 12/22] hw/sparc: use ARRAY_SIZE() macro, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 06/22] configure: Detect native NetBSD curses(3), Michael Tokarev, 2017/06/04