|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH] tcg: allocate TB structs before the corresponding translated code |
Date: | Sun, 4 Jun 2017 10:47:23 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 06/02/2017 04:39 PM, Emilio G. Cota wrote:
+ aligned = (void *)ROUND_UP((uintptr_t)s->code_gen_ptr, 64);
I would prefer that this and
+} QEMU_ALIGNED(64);
this both use a define. We may well have to adjust this for different hosts. In particular I'm thinking of PPC64 which would prefer 128.
+ if (unlikely(!tcg_ctx.tb_ctx.tbs_size)) { + tcg_ctx.tb_ctx.tbs_size = 1024; + }
And I know that you resize this on demand, but surely we can avoid some startup slowdown by picking a more reasonable initial estimate here. Like 32k or 64k.
Otherwise this looks good. I'll have to have a more detailed look at the differences in the generated code later.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |