[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/69] target/s390x tcg patches
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PULL 00/69] target/s390x tcg patches |
Date: |
Sun, 4 Jun 2017 21:54:35 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On 2017-06-04 11:32, address@hidden wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
>
> Subject: [Qemu-devel] [PULL 00/69] target/s390x tcg patches
> Message-id: address@hidden
> Type: series
>
[snip]
> /var/tmp/patchew-tester-tmp-9ddil10x/src/target/s390x/mem_helper.c: In
> function ‘helper_lpq’:
> /var/tmp/patchew-tester-tmp-9ddil10x/src/target/s390x/mem_helper.c:1675:16:
> error: implicit declaration of function ‘helper_atomic_ldo_be_mmu’
> [-Werror=implicit-function-declaration]
> Int128 v = helper_atomic_ldo_be_mmu(env, addr, oi, ra);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> /var/tmp/patchew-tester-tmp-9ddil10x/src/target/s390x/mem_helper.c:1675:5:
> error: nested extern declaration of ‘helper_atomic_ldo_be_mmu’
> [-Werror=nested-externs]
> Int128 v = helper_atomic_ldo_be_mmu(env, addr, oi, ra);
> ^~~~~~
> /var/tmp/patchew-tester-tmp-9ddil10x/src/target/s390x/mem_helper.c: In
> function ‘helper_stpq’:
> /var/tmp/patchew-tester-tmp-9ddil10x/src/target/s390x/mem_helper.c:1690:5:
> error: implicit declaration of function ‘helper_atomic_sto_be_mmu’
> [-Werror=implicit-function-declaration]
> helper_atomic_sto_be_mmu(env, addr, v, oi, ra);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> /var/tmp/patchew-tester-tmp-9ddil10x/src/target/s390x/mem_helper.c:1690:5:
> error: nested extern declaration of ‘helper_atomic_sto_be_mmu’
> [-Werror=nested-externs]
> cc1: all warnings being treated as errors
> /var/tmp/patchew-tester-tmp-9ddil10x/src/rules.mak:69: recipe for target
> 'target/s390x/mem_helper.o' failed
> make[1]: *** [target/s390x/mem_helper.o] Error 1
> Makefile:327: recipe for target 'subdir-s390x-softmmu' failed
> make: *** [subdir-s390x-softmmu] Error 2
> make: *** Waiting for unfinished jobs....
Sorry for not testing test building those patches properly.
The best is probably to just drop them for now as they are independent
besides some easy conflict to solve in helper.h. Properly implementing
the !CONFIG_ATOMIC128 case requires to check the alignment and it's
better done with the check_alignment function introduced later in the
series.
I'll send new patches for those two instructions in the next hours.
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
- [Qemu-devel] [PULL 59/69] target/s390x: improve MOVE LONG and MOVE LONG EXTENDED, (continued)
- [Qemu-devel] [PULL 59/69] target/s390x: improve MOVE LONG and MOVE LONG EXTENDED, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 62/69] target/s390x: implement PACK ASCII, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 63/69] target/s390x: implement PACK UNICODE, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 66/69] target/s390x: implement TEST DECIMAL, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 65/69] target/s390x: implement UNPACK UNICODE, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 67/69] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 68/69] target/s390x: mark ETF2 and ETF2-ENH facilities as available, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 64/69] target/s390x: implement UNPACK ASCII, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 69/69] target/s390x: addressing exceptions are suppressing, Richard Henderson, 2017/06/04
- Re: [Qemu-devel] [PULL 00/69] target/s390x tcg patches, no-reply, 2017/06/04
- Re: [Qemu-devel] [PULL 00/69] target/s390x tcg patches,
Aurelien Jarno <=
- Re: [Qemu-devel] [PULL 00/69] target/s390x tcg patches, Aurelien Jarno, 2017/06/04