[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] arm_gicv3: Fix ICC_BPR1 reset value when EL3 no
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] arm_gicv3: Fix ICC_BPR1 reset value when EL3 not implemented |
Date: |
Wed, 7 Jun 2017 18:23:43 +0100 |
On 7 June 2017 at 17:13, Alex Bennée <address@hidden> wrote:
>
> Peter Maydell <address@hidden> writes:
>
>> If EL3 is not implemented (ie only one security state) then the
>> one and only ICC_BPR1 register behaves like the Non-secure
>> ICC_BPR1 in an EL3-present configuration. In particular, its
>> reset value is GIC_MIN_BPR_NS, not GIC_MIN_BPR.
>>
>> Correct the erroneous reset value; this fixes a problem where
>> we might hit the assert added in commit a89ff39ee901.
>>
>> Reported-by: Alex Bennée <address@hidden>
>> Signed-off-by: Peter Maydell <address@hidden>
>
> Reviewed-by: Alex Bennée <address@hidden>
> Tested-by: Alex Bennée <address@hidden>
Thanks; applied to master as a fix for an assertion failure
(still not sure why I don't see it).
-- PMM