[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/43] qapi: minor refactoring
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/43] qapi: minor refactoring |
Date: |
Thu, 08 Jun 2017 16:57:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Lets title this
qapi: Clean up qobject_input_type_number() control flow
Marc-André Lureau <address@hidden> writes:
> Use the more common pattern to error out.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> qapi/qobject-input-visitor.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c
> index eac40f618a..26ef49a60b 100644
> --- a/qapi/qobject-input-visitor.c
> +++ b/qapi/qobject-input-visitor.c
> @@ -547,13 +547,13 @@ static void qobject_input_type_number(Visitor *v, const
> char *name, double *obj,
> }
>
> qfloat = qobject_to_qfloat(qobj);
> - if (qfloat) {
> - *obj = qfloat_get_double(qobject_to_qfloat(qobj));
> + if (!qfloat) {
> + error_setg(errp, QERR_INVALID_PARAMETER_TYPE,
> + full_name(qiv, name), "number");
> return;
> }
>
> - error_setg(errp, QERR_INVALID_PARAMETER_TYPE,
> - full_name(qiv, name), "number");
> + *obj = qfloat_get_double(qobject_to_qfloat(qobj));
> }
>
> static void qobject_input_type_number_keyval(Visitor *v, const char *name,
Preferably with the more descriptive commit message
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH v3 00/43] qobject/qapi: add uint type, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 00/43] qobject/qapi: add uint type, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 01/43] qdev: remove PropertyInfo.qtype field, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 02/43] object: fix potential leak in getters, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 03/43] tests: Remove test cases for alternates of 'number' and 'int', Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 04/43] tests: add more int/number ranges checks, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 05/43] qapi: minor refactoring, Marc-André Lureau, 2017/06/07
- Re: [Qemu-devel] [PATCH v3 05/43] qapi: minor refactoring,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 07/43] qapi: Remove visit_start_alternate() parameter promote_int, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 06/43] qapi: merge QInt and QFloat in QNum, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 08/43] tests: remove /{qnum, qlist, dict}/destroy test, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 09/43] qnum: add uint type, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 10/43] json: learn to parse uint64 numbers, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 11/43] qapi: update the qobject visitor to use QNUM_U64, Marc-André Lureau, 2017/06/07