[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 0/4] Improve error reporting
From: |
Mao Zhongyi |
Subject: |
[Qemu-devel] [PATCH v3 0/4] Improve error reporting |
Date: |
Fri, 9 Jun 2017 18:01:44 +0800 |
Daniel's patch(commit 6701e551, Revert "Change net/socket.c to use socket_*()
functions" again) has been in upstream. Continue this patchset.
In v2, this series convert the non-blocking connect mechanism to QIOchannel
by replace the socket_connect(), and some errors also are converted to Error.
The v2 related discussion was listed on:
https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg04886.html
v3:
* PATCH 01 is suggested by Markus and Daniel that removes the dubious 'default'
case
in the net_socket_fd_init(). Jason agreed.
* PATCH 02 is redoing previous patch 4.
* PATCH 04 is redoing previous patch 2, improves sort of error messages.
v2:
* PATCH 02 reworking of patch 2 following Markus's suggestion that convert
error_report()
in the function called by net_socket_*_init() to Error. Also add
many error
handling information.
* PATCH 03 net_socket_mcast_create(), net_socket_fd_init_dgram() and
net_socket_fd_init()
use the function such as fprintf, perror to report an error message.
Convert it
to Error.
* PATCH 04 parse_host_port() may fail without reporting an error. Now, fix it
to set an
error when it fails.
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Mao Zhongyi (4):
net/socket: Drop the odd 'default' case and comment
net/net: Convert parse_host_port() to Error
net/socket: Convert error report message to Error
net/socket: Improve -net socket error reporting
include/qemu/sockets.h | 2 +-
net/net.c | 21 ++++++--
net/socket.c | 138 +++++++++++++++++++++++++++++--------------------
3 files changed, 98 insertions(+), 63 deletions(-)
--
2.9.3
- [Qemu-devel] [PATCH v3 0/4] Improve error reporting,
Mao Zhongyi <=