[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 2/7] pci: Add comment for pci_add_capability2()
From: |
Mao Zhongyi |
Subject: |
[Qemu-devel] [PATCH v4 2/7] pci: Add comment for pci_add_capability2() |
Date: |
Fri, 9 Jun 2017 19:24:37 +0800 |
Comments for pci_add_capability2() to explain the return
value. This may help to make a correct return value check
for its callers.
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Mao Zhongyi <address@hidden>
---
hw/pci/pci.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 53566b8..b73bfea 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -2276,6 +2276,12 @@ int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
return ret;
}
+/*
+ * On success, pci_add_capability2() returns a positive value
+ * that the offset of the pci capability.
+ * On failure, it sets an error and returns a negative error
+ * code.
+ */
int pci_add_capability2(PCIDevice *pdev, uint8_t cap_id,
uint8_t offset, uint8_t size,
Error **errp)
--
2.9.3
- [Qemu-devel] [PATCH v4 0/7] Convert to realize and cleanup, Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 2/7] pci: Add comment for pci_add_capability2(),
Mao Zhongyi <=
- [Qemu-devel] [PATCH v4 5/7] pci: Replace pci_add_capability() with pci_add_capability2(), Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 1/7] pci: Clean up error checking in pci_add_capability(), Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 7/7] pci: Convert shpc_init() to Error, Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 4/7] pci: Make errp the last parameter of pci_add_capability(), Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 6/7] pci: Convert to realize, Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 3/7] pci: Fix the return value checking, Mao Zhongyi, 2017/06/09