[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 13/41] q35: fix get_mmcfg_size to use uint64 visitor
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 13/41] q35: fix get_mmcfg_size to use uint64 visitor |
Date: |
Fri, 9 Jun 2017 15:46:57 +0200 |
From: Marc-André Lureau <address@hidden>
e->size is hwaddr, i.e. uint64_t. We silently truncate.
Signed-off-by: Marc-André Lureau <address@hidden>
Suggested-by: Markus Armbruster <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/pci-host/q35.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index cd5c496..e8a04d3 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -129,9 +129,8 @@ static void q35_host_get_mmcfg_size(Object *obj, Visitor
*v, const char *name,
void *opaque, Error **errp)
{
PCIExpressHost *e = PCIE_HOST_BRIDGE(obj);
- uint32_t value = e->size;
- visit_type_uint32(v, name, &value, errp);
+ visit_type_uint64(v, name, &e->size, errp);
}
static Property mch_props[] = {
--
2.7.5
- [Qemu-devel] [PULL 26/41] platform-bus: use get_uint() for "addr" property, (continued)
- [Qemu-devel] [PULL 26/41] platform-bus: use get_uint() for "addr" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 30/41] pc: use get_uint() for "iobase" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 36/41] pvpanic: use get_uint() for "ioport" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 23/41] pcihp: use get_uint() for "bsel" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 14/41] object: use more specific property type names, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 32/41] pc: use get_uint() for "hpet-intcap" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 38/41] numa: use get_uint() for "size" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 41/41] tests/qdict: check more get_try_int() cases, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 27/41] acpi: use get_uint() for "acpi-pcihp-io*" properties, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 18/41] apic-common: make "id" property a uint32, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 13/41] q35: fix get_mmcfg_size to use uint64 visitor,
Markus Armbruster <=
- [Qemu-devel] [PULL 25/41] bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base", Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 31/41] pc: use get_uint() for "apic-id" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 17/41] qdev: avoid type casts between signed and unsigned, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 07/41] qapi: Remove visit_start_alternate() parameter promote_int, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 08/41] tests: remove /{qnum, qlist, dict}/destroy test, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 37/41] pnv-core: use get_uint() for "core-pir" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 34/41] arm: use get_uint() for "mp-affinity" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 28/41] acpi: use get_uint() for various acpi properties, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 22/41] pc-dimm: make "size" property uint64, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 21/41] pc-dimm: use get_uint() for dimm properties, Markus Armbruster, 2017/06/09