[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_c
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1() |
Date: |
Mon, 12 Jun 2017 15:03:53 +0200 |
On Mon, 2017-06-12 at 13:37 +0200, Igor Mammedov wrote:
> On Sat, 10 Jun 2017 13:30:18 +0100
> Mark Cave-Ayland <address@hidden> wrote:
>
> > The dma_enabled property enables us to set the FW_CFG_ID version
> > accordingly.
>
> it might be not safe as patch reorders FW_CFG_ID entry.
>
> (I recall there were patches that sorted fwcfg entries,
> but it's worth checking that it won't break migration)
>
> CCing Gerd, maybe he would recall how it works.
http://git.qemu.org/?p=qemu.git;a=blob;f=hw/nvram/fw_cfg.c;h=316fca9bc1
dadf8777ad9a9c238381702022bc56;hb=HEAD#l723
So, should be safe to shuffle around stuff.
cheers,
Gerd
- Re: [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init, (continued)