[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 07/10] tcg/arm: Try pc-relative addresses for movi
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 07/10] tcg/arm: Try pc-relative addresses for movi |
Date: |
Tue, 13 Jun 2017 22:23:08 -0700 |
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/arm/tcg-target.inc.c | 40 +++++++++++++++++++++++++++-------------
1 file changed, 27 insertions(+), 13 deletions(-)
diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c
index fce382f..42370e5 100644
--- a/tcg/arm/tcg-target.inc.c
+++ b/tcg/arm/tcg-target.inc.c
@@ -418,23 +418,37 @@ static inline void tcg_out_dat_imm(TCGContext *s,
static void tcg_out_movi32(TCGContext *s, int cond, int rd, uint32_t arg)
{
- int rot, opc, rn;
-
- /* For armv7, make sure not to use movw+movt when mov/mvn would do.
- Speed things up by only checking when movt would be required.
- Prior to armv7, have one go at fully rotated immediates before
- doing the decomposition thing below. */
- if (!use_armv7_instructions || (arg & 0xffff0000)) {
- rot = encode_imm(arg);
+ int rot, opc, rn, diff;
+
+ /* Check a single MOV/MVN before anything else. */
+ rot = encode_imm(arg);
+ if (rot >= 0) {
+ tcg_out_dat_imm(s, cond, ARITH_MOV, rd, 0,
+ rotl(arg, rot) | (rot << 7));
+ return;
+ }
+ rot = encode_imm(~arg);
+ if (rot >= 0) {
+ tcg_out_dat_imm(s, cond, ARITH_MVN, rd, 0,
+ rotl(~arg, rot) | (rot << 7));
+ return;
+ }
+
+ /* Check for a pc-relative address. This will usually be the TB,
+ or within the TB, which is immediately before the code block. */
+ diff = arg - ((intptr_t)s->code_ptr + 8);
+ if (diff >= 0) {
+ rot = encode_imm(diff);
if (rot >= 0) {
- tcg_out_dat_imm(s, cond, ARITH_MOV, rd, 0,
- rotl(arg, rot) | (rot << 7));
+ tcg_out_dat_imm(s, cond, ARITH_ADD, rd, TCG_REG_PC,
+ rotl(diff, rot) | (rot << 7));
return;
}
- rot = encode_imm(~arg);
+ } else {
+ rot = encode_imm(-diff);
if (rot >= 0) {
- tcg_out_dat_imm(s, cond, ARITH_MVN, rd, 0,
- rotl(~arg, rot) | (rot << 7));
+ tcg_out_dat_imm(s, cond, ARITH_SUB, rd, TCG_REG_PC,
+ rotl(-diff, rot) | (rot << 7));
return;
}
}
--
2.9.4
- [Qemu-devel] [PULL 00/10] TCG queued patches, Richard Henderson, 2017/06/14
- [Qemu-devel] [PULL 03/10] translate-all: consolidate tb init in tb_gen_code, Richard Henderson, 2017/06/14
- [Qemu-devel] [PULL 01/10] util: add cacheinfo, Richard Henderson, 2017/06/14
- [Qemu-devel] [PULL 02/10] tcg: allocate TB structs before the corresponding translated code, Richard Henderson, 2017/06/14
- [Qemu-devel] [PULL 04/10] tcg/aarch64: Use ADR in tcg_out_movi, Richard Henderson, 2017/06/14
- [Qemu-devel] [PULL 05/10] tcg/arm: Use indirect branch for goto_tb, Richard Henderson, 2017/06/14
- [Qemu-devel] [PULL 06/10] tcg/arm: Remove limit on code buffer size, Richard Henderson, 2017/06/14
- [Qemu-devel] [PULL 07/10] tcg/arm: Try pc-relative addresses for movi,
Richard Henderson <=
- [Qemu-devel] [PULL 09/10] Revert "target/aarch64: optimize indirect branches", Richard Henderson, 2017/06/14
- [Qemu-devel] [PULL 08/10] tcg/arm: Use ldr (literal) for goto_tb, Richard Henderson, 2017/06/14
- [Qemu-devel] [PULL 10/10] tcg: Remove tb_htable_lookup from helper_lookup_tb_ptr, Richard Henderson, 2017/06/14
- Re: [Qemu-devel] [PULL 00/10] TCG queued patches, no-reply, 2017/06/14
- Re: [Qemu-devel] [PULL 00/10] TCG queued patches, no-reply, 2017/06/14
- Re: [Qemu-devel] [PULL 00/10] TCG queued patches, Richard Henderson, 2017/06/14