[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] migration: Test for disabled features on re
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] migration: Test for disabled features on reception |
Date: |
Wed, 14 Jun 2017 10:45:42 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> Right now, if we receive a compressed page while this features are
>> disabled, Bad Things (TM) can happen. Just add a test for them.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>
> Yes, my R-b stands, there could be someone somewhere driving this by
> hand who might get caught out, but seems saner this way.
>
>> --
>>
>> I had XBZRLE here also, but it don't need extra resources on
>> destination, only on source. Additionally libvirt don't enable it on
>> destination, so don't put it here.
>> ---
>> migration/ram.c | 16 +++++++++++++++-
>> 1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/migration/ram.c b/migration/ram.c
>> index f35d65a..f2d1bce 100644
>> --- a/migration/ram.c
>> +++ b/migration/ram.c
>> @@ -2477,7 +2477,7 @@ static int ram_load_postcopy(QEMUFile *f)
>>
>> static int ram_load(QEMUFile *f, void *opaque, int version_id)
>> {
>> - int flags = 0, ret = 0;
>> + int flags = 0, ret = 0, invalid_flags;
>> static uint64_t seq_iter;
>> int len = 0;
>> /*
>> @@ -2494,6 +2494,11 @@ static int ram_load(QEMUFile *f, void *opaque, int
>> version_id)
>> ret = -EINVAL;
>> }
>>
>> + invalid_flags = 0;
>
> why didn't you use = 0 in the declaration like the rest of the flags?
> (Only minor)
Costume :-(
Changed to common style there.
Thanks, Juan.