[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 11/13] migration: move only_migratable to Mig
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v3 11/13] migration: move only_migratable to MigrationState |
Date: |
Wed, 21 Jun 2017 11:07:28 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Jun 19, 2017 at 05:50:50PM +0200, Juan Quintela wrote:
> Peter Xu <address@hidden> wrote:
> > One less global variable, and it does only matter with migration.
> >
> > We keep the old "--only-migratable" option, but also now we support:
> >
> > -global migration.only-migratable=true
> >
> > Currently still keep the old interface.
> >
> > Hmm, now vl.c has no way to access migrate_get_current(). Export a
> > function for it to setup only_migratable.
> >
> > Signed-off-by: Peter Xu <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
>
> If you have to respin
So there will be. :-)
>
> +void migration_only_migratable_set(bool only_migratable);
> +
>
> only is used with "true". I think that it is easier without parameter.
>
> But it is just a question of taste, so, as you are the one doing the
> code ....
Sure. Thanks,
--
Peter Xu
- Re: [Qemu-devel] [PATCH v3 06/13] kvm: let kvm use AccelState.global_props, (continued)
[Qemu-devel] [PATCH v3 07/13] tcg: use AccelState.global_props, Peter Xu, 2017/06/19
[Qemu-devel] [PATCH v3 08/13] trace: add qdev_global_prop_apply, Peter Xu, 2017/06/19
[Qemu-devel] [PATCH v3 09/13] migration: let MigrationState be a qdev, Peter Xu, 2017/06/19
[Qemu-devel] [PATCH v3 10/13] migration: move global_state.optional out, Peter Xu, 2017/06/19
[Qemu-devel] [PATCH v3 11/13] migration: move only_migratable to MigrationState, Peter Xu, 2017/06/19
[Qemu-devel] [PATCH v3 12/13] migration: move skip_configuration out, Peter Xu, 2017/06/19
[Qemu-devel] [PATCH v3 13/13] migration: move skip_section_footers, Peter Xu, 2017/06/19
Re: [Qemu-devel] [PATCH v3 00/13] migration: objectify MigrationState, Juan Quintela, 2017/06/19