[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end |
Date: |
Tue, 20 Jun 2017 20:43:38 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end
Type: series
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
4a3cb84 tcg: Store pointers to temporaries directly in TCGArg
02ed29c tcg: Define separate structures for TCGv_*
5cf0662 tcg: Use per-temp state data in optimize
5fdbde2 tcg: Export temp_idx
15a10ce tcg: Remove unused TCG_CALL_DUMMY_TCGV
4fa8938 tcg: Change temp_allocate_frame arg to TCGTemp
4c11a05 tcg: Avoid loops against variable bounds
6976828 tcg: Use per-temp state data in liveness
1f69381 tcg: Introduce temp_arg
af94763 tcg: Return NULL temp for TCG_CALL_DUMMY_ARG
cb3e123 tcg: Add temp_global bit to TCGTemp
11681e4 tcg: Introduce arg_temp
0d81916 tcg: Propagate TCGOp down to allocators
b2dc5b3 tcg: Propagate args to op->args in tcg.c
d095548 tcg: Propagate args to op->args in optimizer
33e16df tcg: Merge opcode arguments into TCGOp
=== OUTPUT BEGIN ===
Checking PATCH 1/16: tcg: Merge opcode arguments into TCGOp...
ERROR: spaces prohibited around that ':' (ctx:WxW)
#480: FILE: tcg/tcg.h:619:
+ unsigned calli : 4; /* 12 */
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#481: FILE: tcg/tcg.h:620:
+ unsigned callo : 2; /* 14 */
^
ERROR: space prohibited before that ':' (ctx:WxW)
#482: FILE: tcg/tcg.h:621:
+ unsigned : 2; /* 16 */
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#487: FILE: tcg/tcg.h:624:
+ unsigned prev : 16; /* 32 */
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#488: FILE: tcg/tcg.h:625:
+ unsigned next : 16; /* 48 */
^
total: 5 errors, 0 warnings, 481 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/16: tcg: Propagate args to op->args in optimizer...
ERROR: spaces required around that '-' (ctx:VxV)
#644: FILE: tcg/optimize.c:1165:
+ tcg_opt_gen_mov(s, op, op->args[0], op->args[4-tmp]);
^
total: 1 errors, 0 warnings, 912 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/16: tcg: Propagate args to op->args in tcg.c...
Checking PATCH 4/16: tcg: Propagate TCGOp down to allocators...
Checking PATCH 5/16: tcg: Introduce arg_temp...
Checking PATCH 6/16: tcg: Add temp_global bit to TCGTemp...
Checking PATCH 7/16: tcg: Return NULL temp for TCG_CALL_DUMMY_ARG...
Checking PATCH 8/16: tcg: Introduce temp_arg...
Checking PATCH 9/16: tcg: Use per-temp state data in liveness...
WARNING: line over 80 characters
#186: FILE: tcg/tcg.c:1572:
+ } else if (arg_temp(op->args[0])->state == TS_DEAD &&
have_opc_new2) {
total: 0 errors, 1 warnings, 442 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/16: tcg: Avoid loops against variable bounds...
Checking PATCH 11/16: tcg: Change temp_allocate_frame arg to TCGTemp...
Checking PATCH 12/16: tcg: Remove unused TCG_CALL_DUMMY_TCGV...
Checking PATCH 13/16: tcg: Export temp_idx...
Checking PATCH 14/16: tcg: Use per-temp state data in optimize...
Checking PATCH 15/16: tcg: Define separate structures for TCGv_*...
Checking PATCH 16/16: tcg: Store pointers to temporaries directly in TCGArg...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-devel] [PATCH 09/16] tcg: Use per-temp state data in liveness, (continued)
- [Qemu-devel] [PATCH 08/16] tcg: Introduce temp_arg, Richard Henderson, 2017/06/20
- [Qemu-devel] [PATCH 12/16] tcg: Remove unused TCG_CALL_DUMMY_TCGV, Richard Henderson, 2017/06/20
- [Qemu-devel] [PATCH 13/16] tcg: Export temp_idx, Richard Henderson, 2017/06/20
- [Qemu-devel] [PATCH 15/16] tcg: Define separate structures for TCGv_*, Richard Henderson, 2017/06/20
- [Qemu-devel] [PATCH 16/16] tcg: Store pointers to temporaries directly in TCGArg, Richard Henderson, 2017/06/20
- [Qemu-devel] [PATCH 14/16] tcg: Use per-temp state data in optimize, Richard Henderson, 2017/06/20
- Re: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end,
no-reply <=
- Re: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end, Alex Bennée, 2017/06/26