[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 01/10] machine: export register_compat_prop()
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH v4 01/10] machine: export register_compat_prop() |
Date: |
Wed, 21 Jun 2017 15:51:59 +0800 |
We have HW_COMPAT_*, however that's only bound to machines, not other
things (like accelerators). Behind it, it was register_compat_prop()
that played the trick. Let's export the function for further use
outside HW_COMPAT_* magic.
Meanwhile, move it to qdev-properties.c where seems more proper (since
it'll be used not only in machine codes).
Signed-off-by: Peter Xu <address@hidden>
---
hw/core/machine.c | 13 -------------
hw/core/qdev-properties.c | 13 +++++++++++++
include/hw/qdev-properties.h | 3 +++
3 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 2e7e977..ecb5552 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -770,19 +770,6 @@ static void machine_class_finalize(ObjectClass *klass,
void *data)
g_free(mc->name);
}
-static void register_compat_prop(const char *driver,
- const char *property,
- const char *value)
-{
- GlobalProperty *p = g_new0(GlobalProperty, 1);
- /* Machine compat_props must never cause errors: */
- p->errp = &error_abort;
- p->driver = driver;
- p->property = property;
- p->value = value;
- qdev_prop_register_global(p);
-}
-
static void machine_register_compat_for_subclass(ObjectClass *oc, void *opaque)
{
GlobalProperty *p = opaque;
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 9f1a497..6ff1ac3 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -1047,6 +1047,19 @@ void qdev_prop_register_global(GlobalProperty *prop)
global_props = g_list_append(global_props, prop);
}
+void register_compat_prop(const char *driver,
+ const char *property,
+ const char *value)
+{
+ GlobalProperty *p = g_new0(GlobalProperty, 1);
+ /* Machine compat_props must never cause errors: */
+ p->errp = &error_abort;
+ p->driver = driver;
+ p->property = property;
+ p->value = value;
+ qdev_prop_register_global(p);
+}
+
void qdev_prop_register_global_list(GlobalProperty *props)
{
int i;
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index d206fc9..1722ca4 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -201,6 +201,9 @@ void qdev_prop_set_globals(DeviceState *dev);
void error_set_from_qdev_prop_error(Error **errp, int ret, DeviceState *dev,
Property *prop, const char *value);
+void register_compat_prop(const char *driver, const char *property,
+ const char *value);
+
/**
* qdev_property_add_static:
* @dev: Device to add the property to.
--
2.7.4
[Qemu-devel] [PATCH v4 01/10] machine: export register_compat_prop(),
Peter Xu <=
[Qemu-devel] [PATCH v4 03/10] vl: clean up global property registerations, Peter Xu, 2017/06/21
[Qemu-devel] [PATCH v4 04/10] migration: let MigrationState be a qdev, Peter Xu, 2017/06/21
[Qemu-devel] [PATCH v4 05/10] migration: move global_state.optional out, Peter Xu, 2017/06/21
[Qemu-devel] [PATCH v4 06/10] migration: move only_migratable to MigrationState, Peter Xu, 2017/06/21
[Qemu-devel] [PATCH v4 07/10] migration: move skip_configuration out, Peter Xu, 2017/06/21
[Qemu-devel] [PATCH v4 08/10] migration: move skip_section_footers, Peter Xu, 2017/06/21