[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 04/10] migration: let MigrationState be a qde
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v4 04/10] migration: let MigrationState be a qdev |
Date: |
Wed, 21 Jun 2017 10:58:29 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Peter Xu <address@hidden> wrote:
> Let the old man "MigrationState" join the object family. Direct benefit
> is that we can start to use all the property features derived from
> current QDev, like: HW_COMPAT_* bits, command line setup for migration
> parameters (so will never need to set them up each time using HMP/QMP,
> this is really, really attractive for test writters), etc.
>
> I see no reason to disallow this happen yet. So let's start from this
> one, to see whether it would be anything good.
>
> Now we init the MigrationState struct statically in main() to make sure
> it's initialized after global properties are applied, since we'll use
> them during creation of the object.
>
> No functional change at all.
>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
- [Qemu-devel] [PATCH v4 00/10] migration: objectify MigrationState, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 02/10] accel: introduce AccelClass.global_props, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 01/10] machine: export register_compat_prop(), Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 03/10] vl: clean up global property registerations, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 04/10] migration: let MigrationState be a qdev, Peter Xu, 2017/06/21
- Re: [Qemu-devel] [PATCH v4 04/10] migration: let MigrationState be a qdev,
Juan Quintela <=
- [Qemu-devel] [PATCH v4 05/10] migration: move global_state.optional out, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 06/10] migration: move only_migratable to MigrationState, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 07/10] migration: move skip_configuration out, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 08/10] migration: move skip_section_footers, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 10/10] migration: hmp: dump globals, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 09/10] migration: merge enforce_config_section somewhat, Peter Xu, 2017/06/21