[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/10] migration: merge enforce_config_sectio
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v4 09/10] migration: merge enforce_config_section somewhat |
Date: |
Wed, 21 Jun 2017 11:02:27 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Peter Xu <address@hidden> wrote:
> These two parameters:
>
> - MachineState::enforce_config_section
> - MigrationState::send_configuration
>
> are playing similar role here. This patch merges the first one into
> second, then we'll have a single place to reference whether we need to
> send the configuration section.
>
> I didn't remove the MachineState.enforce_config_section field since when
> applying that machine property (in machine_set_property()) we haven't
> yet initialized global properties and migration object. Then, it's
> still not easy to pass that boolean to MigrationState at such an early
> time.
>
> A natural benefit for current patch is that now we kept the meaning of
> "enforce-config-section" since it'll still have the highest
> priority (that's what "enforce" mean I guess).
>
> Signed-off-by: Peter Xu <address@hidden>
Nice!!!
Reviewed-by: Juan Quintela <address@hidden>
- [Qemu-devel] [PATCH v4 05/10] migration: move global_state.optional out, (continued)
- [Qemu-devel] [PATCH v4 05/10] migration: move global_state.optional out, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 06/10] migration: move only_migratable to MigrationState, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 07/10] migration: move skip_configuration out, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 08/10] migration: move skip_section_footers, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 10/10] migration: hmp: dump globals, Peter Xu, 2017/06/21
- [Qemu-devel] [PATCH v4 09/10] migration: merge enforce_config_section somewhat, Peter Xu, 2017/06/21
- Re: [Qemu-devel] [PATCH v4 09/10] migration: merge enforce_config_section somewhat,
Juan Quintela <=