[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] xen-disk: only advertize feature-persistent
From: |
Paul Durrant |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] xen-disk: only advertize feature-persistent if grant copy is not available |
Date: |
Wed, 21 Jun 2017 09:35:38 +0000 |
> -----Original Message-----
> From: Roger Pau Monne
> Sent: 21 June 2017 10:18
> To: Stefano Stabellini <address@hidden>
> Cc: Paul Durrant <address@hidden>; address@hidden;
> address@hidden; address@hidden; Anthony Perard
> <address@hidden>; Kevin Wolf <address@hidden>; Max Reitz
> <address@hidden>
> Subject: Re: [PATCH 1/3] xen-disk: only advertize feature-persistent if grant
> copy is not available
>
> On Tue, Jun 20, 2017 at 03:19:33PM -0700, Stefano Stabellini wrote:
> > On Tue, 20 Jun 2017, Paul Durrant wrote:
> > > If grant copy is available then it will always be used in preference to
> > > persistent maps. In this case feature-persistent should not be advertized
> > > to the frontend, otherwise it may needlessly copy data into persistently
> > > granted buffers.
> > >
> > > Signed-off-by: Paul Durrant <address@hidden>
> >
> > CC'ing Roger.
> >
> > It is true that using feature-persistent together with grant copies is a
> > a very bad idea.
> >
> > But this change enstablishes an explicit preference of
> > feature_grant_copy over feature-persistent in the xen_disk backend. It
> > is not obvious to me that it should be the case.
> >
> > Why is feature_grant_copy (without feature-persistent) better than
> > feature-persistent (without feature_grant_copy)? Shouldn't we simply
> > avoid grant copies to copy data to persistent grants?
>
> When using persistent grants the frontend must always copy data from
> the buffer to the persistent grant, there's no way to avoid this.
>
> Using grant_copy we move the copy from the frontend to the backend,
> which means the CPU time of the copy is accounted to the backend. This
> is not ideal, but IMHO it's better than persistent grants because it
> avoids keeping a pool of mapped grants that consume memory and make
> the code more complex.
>
> Do you have some performance data showing the difference between
> persistent grants vs grant copy?
>
No, but I can get some :-)
For a little background... I've been trying to push throughput of fio running
in a debian stretch guest on my skull canyon NUC. When I started out, I was
getting ~100MBbs. When I finished, with this patch, the IOThreads one, the
multi-page ring one and a bit of hackery to turn off all the aio flushes that
seem to occur even if the image is opened with O_DIRECT, I was getting
~960Mbps... which is about line rate for the SSD in the in NUC.
So, I'll force use of persistent grants on and see what sort of throughput I
get.
Cheers,
Paul
> Roger.
[Qemu-devel] [PATCH 3/3] xen-disk: use an IOThread per instance, Paul Durrant, 2017/06/20
[Qemu-devel] [PATCH 2/3] xen-disk: add support for multi-page shared rings, Paul Durrant, 2017/06/20